Test unicode emails #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesTyler
reviewed
Feb 6, 2017
| @@ -11,6 +11,9 @@ | |||
| ["test@nominet.org.uk", "valid"], | |||
| ["test@about.museum", "valid"], | |||
| ["a@iana.org", "valid"], | |||
| ["êjness@iana.com", "valid"], | |||
| ["ñoñó1234@iana.com", "valid"], | |||
There was a problem hiding this comment.
@skeggse even with unicode character support, this fails on the DNS lookup because of iana.com vs iana.org.
WesTyler
reviewed
Feb 6, 2017
| @@ -11,6 +11,9 @@ | |||
| ["test@nominet.org.uk", "valid"], | |||
| ["test@about.museum", "valid"], | |||
| ["a@iana.org", "valid"], | |||
| ["êjness@iana.com", "valid"], | |||
| ["ñoñó1234@iana.com", "valid"], | |||
| ["伊昭傑@郵件.商務", "valid"], | |||
There was a problem hiding this comment.
@skeggse same DNS issue here. The MX resolution fails for 郵件.商務
There was a problem hiding this comment.
Hm, gotcha.
This is a good problem to notice. This also indicates that unicode support in the domain names will break checkDNS, as the resolve family of functions are not unicode compatible or aware, which goes back to my question about punycode. It seems we'll need just a little more to avoid breaking existing functionality in unexpected ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #17