New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update storybook 7 and creevey, update webpack in validations, update TestPages #3417
Merged
HelenaIsh
merged 103 commits into
update-react-ui-all-dev-dependencies
from
update-storybook-7
May 22, 2024
Merged
feat: update storybook 7 and creevey, update webpack in validations, update TestPages #3417
HelenaIsh
merged 103 commits into
update-react-ui-all-dev-dependencies
from
update-storybook-7
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
С криви несколько проблем:
|
HelenaIsh
changed the title
Update storybook 7
feat: update storybook 7 and creevey, update webpack in validations
May 17, 2024
HelenaIsh
force-pushed
the
update-storybook-7
branch
from
May 20, 2024 07:56
141102a
to
ce40c25
Compare
HelenaIsh
force-pushed
the
update-storybook-7
branch
2 times, most recently
from
May 21, 2024 08:36
88bf801
to
dd67654
Compare
HelenaIsh
changed the title
feat: update storybook 7 and creevey, update webpack in validations
feat: update storybook 7 and creevey, update webpack in validations, update TestPages
May 21, 2024
HelenaIsh
force-pushed
the
update-storybook-7
branch
from
May 21, 2024 11:20
2b3bcba
to
ab24131
Compare
HelenaIsh
merged commit May 22, 2024
71e5e4e
into
update-react-ui-all-dev-dependencies
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
В данном ПР обновила
storybook
до 7 версии иcreevey
. Из-за конфликта зависимостей пришлось обновитьbabel
иwebpack
в пакете валидаций и в пакетеreact-ui-testing/TestPages
(там обновила сразу все зависимости)Решение
Вынесла тесты в отдельные файлы по примеру ПР #3002
Возникли проблемы с типизацией
globalObject
. после обновления (d2f2e3b) webpack в валидациях. Поправила типы вручную.Заскипала несколько тестов в firefox
!!! BreakingChanges !!!
Переименовала метод
static
вSelect
'e наstaticElement
так как static - зарезервированное слово и Select в strict mode падает с ошибкойreact-ui
6.4.22
7.6.18
8.1.1
6.4.22
7.6.18
8.1.1
6.4.22
7.6.18
8.1.1
^6.5.16
7.6.18
8.1.1
6.4.22
7.6.18
8.1.1
7.6.18
8.1.1
0.8.2-fix-wait.2
0.9.0-beta.12
0.9.0-beta.12
7.6.18
8.1.1
react-ui-validations
^7.16.5
^7.24.5
7.24.5
7.16.5
7.24.1
7.24.1
^7.16.5
^7.24.3
^7.24.3
^7.16.5
^7.24.5
^7.24.5
^7.16.5
^7.24.1
^7.24.1
6.4.22
8.1.1
^6.4.22
8.1.1
^6.4.22
8.1.1
^8.0.6
^9.1.3
^9.1.3
1.1.0
1.1.1
1.1.1
^3.9.1
^3.37.0
^3.37.0
^4.41.2
^5.91.0
5.91.0
^3.3.10
^5.1.4
5.1.4
3.9.0
5.0.4
5.0.4
react-ui-testing/TestPages
^7.16.5
^7.24.5
7.24.5
^7.16.5
^7.24.5
7.24.5
^7.16.5
^7.24.1
7.24.1
^17.0.37
^18.3.2
18.3.2
^8.2.3
^9.1.3
9.1.3
^6.26.0
^6.26.0
6.26.0
^7.0.3
^7.0.3
7.0.3
^3.0.0
^3.0.0
3.0.0
^5.2.7
^7.1.1
7.1.1
^3.0.2
^3.0.2
3.0.2
^6.2.0
^6.2.0
6.2.0
4.5.2
5.6.0
5.6.0
4.1.1
4.2.0
4.2.0
7.3.0
12.2.0
12.2.0
^3.2.1
^3.2.1
3.2.1
^15.7.2
^15.8.1
15.8.1
^5.2.0
^6.23.1
6.23.1
^0.7.2
^0.7.2
0.7.2
^7.5.2
^7.6.2
7.6.2
^0.8.5
^0.8.5
0.8.5
^2.0.0
^4.0.0
4.0.0
^5.2.1
^6.1.11
6.1.11
^4.41.2
^5.91.0
5.91.0
^3.11.0
^5.0.4
5.0.4
Ссылки
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
⬜ unit-тесты для логики
⬜ скриншоты для верстки и кросс-браузерности
✅ нерелевантно
Добавлена (обновлена) документация
⬜ styleguidist для пропов и примеров использования компонентов
⬜ jsdoc для утилит и хелперов
⬜ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md
,contributing.md
и др.)✅ нерелевантно
Изменения корректно типизированы
✅ без использования
any
(см. PR2856
)⬜ нерелевантно
Прочее
✅ все тесты и линтеры на CI проходят
✅ в коде нет лишних изменений
✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)