Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to be done:
common_log
will be removed. We must migrate to JSON log. By migrating to JSON log,. we could also filter User-Agent in our ELK stack. Deprecate and remove common_log field from access logs and single_field encoder caddyserver/caddy#4148ftp.sjtu.edu.cn
, which will fallback to NIC's cert after Let's Encrypt fails. We won't need to use a separate PR to specify certs. https://caddyserver.com/docs/automatic-https#issuer-fallback