add skipPackageNameForCaller #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex:
```golang
logrus.SetSkipPackageNameForCaller("tsl/core/log")
logrus.SetSkipPackageNameForCaller("github.com/go-xorm/xorm")
```
|
this should help in resolving #867 too |
lavoiesl
reviewed
Mar 14, 2019
| @@ -40,6 +40,11 @@ func init() { | |||
| minimumCallerDepth = 1 | |||
| } | |||
|
|
|||
| // Set the global qualified package name. | |||
There was a problem hiding this comment.
Add the examples here as well.
entry.go
Outdated
| } else { | ||
| minimumCallerDepth = knownLogrusFrames | ||
| } | ||
| skipPackageNameForCaller[getPackageName(runtime.FuncForPC(pcs[0]).Name())] = true |
There was a problem hiding this comment.
I’d prefer having a local logrusPackage variable, this is quite hard to read.
entry.go
Outdated
| // now that we have the cache, we can skip a minimum count of known-logrus functions | ||
| // XXX this is dubious, the number of frames may vary store an entry in a logger interface | ||
| minimumCallerDepth = knownLogrusFrames | ||
| if len(skipPackageNameForCaller) != 0 { |
There was a problem hiding this comment.
Can you explain what is going on here?
I have the impression minimumCallerDepth = knownLogrusFrames should remain the same.
Co-Authored-By: tossp <code@tossp.com>
|
I'm not such fan of the interface, I wonder if it would not be more practical for the user to provide a callback function returning a boolean which would allow to implement any kind of logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just an implementation. It can only be used, but it's not perfect. I hope there's a better solution.😋
ex:
#887