Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger: fix wrong callback method #893

Merged
merged 1 commit into from Jan 22, 2019
Merged

logger: fix wrong callback method #893

merged 1 commit into from Jan 22, 2019

Commits on Jan 22, 2019

  1. logger: fix wrong callback method 

    Fix wrong callback in `logger.go`, and add test cases:

1. `logger.Warningln` should call `logger.Warnln`, not `logger.Warn`.

2. It's ok for `logger.Print` to call `entry.Info`, but calling `entry.Print`
   is better.

Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
    @jiangxin
    jiangxin committed Jan 22, 2019
    Copy the full SHA
    f61e48b View commit details
    Browse the repository at this point in the history