Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove colored output on windows #864

Merged
merged 3 commits into from Dec 10, 2018
Merged

Remove colored output on windows #864

merged 3 commits into from Dec 10, 2018

Commits on Nov 16, 2018

  1. Disable colored output on windows entirely 

    Currently the textformatter on windows outputs 

``←[31mERRO←[0m[0000] test windows``

when coloring is not disabled explicitly.
However, windows up to windows 8.1 does not support colored output on cmd entirely. Windows 10 added support for it, which is off by default and has to be enabled via registry or environment variable. Therefore i suggest removing colored output on windows entirely to make the output usable again.
    @ceriath
    ceriath committed Nov 16, 2018
    Copy the full SHA
    e902658 View commit details
    Browse the repository at this point in the history

  2. ignore expected color on windows

    @ceriath
    ceriath committed Nov 16, 2018
    Copy the full SHA
    f1b98e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2018

  1. respect ForceColor and environment variables over OS check

    @ceriath
    ceriath committed Dec 9, 2018
    Copy the full SHA
    d962013 View commit details
    Browse the repository at this point in the history