Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #1319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix some typos #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ Features:
# 1.6.0
Fixes:
* end of line cleanup
* revert the entry concurrency bug fix whic leads to deadlock under some circumstances
* revert the entry concurrency bug fix which leads to deadlock under some circumstances
* update dependency on go-windows-terminal-sequences to fix a crash with go 1.14

Features:
Expand Down Expand Up @@ -129,7 +129,7 @@ This new release introduces:
which is mostly useful for logger wrapper
* a fix reverting the immutability of the entry given as parameter to the hooks
a new configuration field of the json formatter in order to put all the fields
in a nested dictionnary
in a nested dictionary
* a new SetOutput method in the Logger
* a new configuration of the textformatter to configure the name of the default keys
* a new configuration of the text formatter to disable the level truncation
Expand Down
4 changes: 2 additions & 2 deletions entry_test.go
View file
Open in desktop
Expand Up @@ -271,7 +271,7 @@ func TestEntryReportCallerRace(t *testing.T) {
entry := NewEntry(logger)

// logging before SetReportCaller has the highest chance of causing a race condition
// to be detected, but doing it twice just to increase the likelyhood of detecting the race
// to be detected, but doing it twice just to increase the likelihood of detecting the race
go func() {
entry.Info("should not race")
}()
Expand All @@ -288,7 +288,7 @@ func TestEntryFormatterRace(t *testing.T) {
entry := NewEntry(logger)

// logging before SetReportCaller has the highest chance of causing a race condition
// to be detected, but doing it twice just to increase the likelyhood of detecting the race
// to be detected, but doing it twice just to increase the likelihood of detecting the race
go func() {
entry.Info("should not race")
}()
Expand Down