Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime panic (via updating dependency) #1276

Closed
wants to merge 1 commit into from
Closed

fix: runtime panic (via updating dependency) #1276

wants to merge 1 commit into from

Conversation

butuzov
Copy link

@butuzov butuzov commented Sep 1, 2021

This PR updates x/sys library so logrus can be used on Darwrin/go1.17
see: golang/go#45702

This PR updates x/sys library so logrus can be used on Darwrin/go1.17
see: golang/go#45702
@butuzov butuzov changed the title fix: update runtime panic fix: runtime panic (via updating dependency) Sep 1, 2021
@butuzov
Copy link
Author

butuzov commented Sep 1, 2021

This is related to #1275

@thaJeztah
Copy link
Collaborator

Perhaps someone could add go 1.17 to CI

In general, I think this is fine to update; that said, if your project uses Logrus and runs into this issue, you should be able to specify a more recent version of golang.org/x/sys in your project's go.mod (if needed with // indirect). This will force go modules to get a more current version than the minimum version required in the logrus go.mod

@butuzov
Copy link
Author

butuzov commented Sep 1, 2021

That's what I did atm, however, isn't a better solution is to fix the issue at the root?

@dgsb
Copy link
Collaborator

dgsb commented Sep 11, 2021

duplicate of #1280

@dgsb dgsb closed this Sep 11, 2021
@butuzov butuzov deleted the x-sys branch September 11, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants