Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run mage with "-v" to not discard output, and move mage to a submodule #1238

Merged
merged 2 commits into from Feb 19, 2021

Commits on Feb 19, 2021

  1. travis: run mage with -v to not discard output

    Before this:
    
        $ go run mage.go lint
        Error: running "/Users/sebastiaan/go/bin/golangci-lint run ./..." failed with exit code 1
        exit status 1
    
        $ go run mage.go test
        Error: running "go test -race -v ./..." failed with exit code 1
        exit status 1
    
    After this:
    
        $ go run mage.go -v lint
        Running target: Lint
        exec: /Users/sebastiaan/go/bin/golangci-lint run ./...
        entry.go:89:6: `iamNotUsed` is unused (deadcode)
        func iamNotUsed() {
             ^
        Error: running "/Users/sebastiaan/go/bin/golangci-lint run ./..." failed with exit code 1
        exit status 1
    
        $ go run mage.go -v test
        Running target: Test
        exec: go test -race -v ./...
        === RUN   TestRegister
        ...
        ?   	github.com/sirupsen/logrus/internal/testutils	[no test files]
        FAIL
        Error: running "go test -race -v ./..." failed with exit code 1
        exit status 1
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Feb 19, 2021
    Copy the full SHA
    feebf74 View commit details
    Browse the repository at this point in the history
  2. move "mage" to a separate module

    Move the magefile related files to a submodule, so that it
    does not become a dependency for logrus itself.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Feb 19, 2021
    Copy the full SHA
    1d8091a View commit details
    Browse the repository at this point in the history