Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify checkIfTerminal for Windows #1088

Merged
merged 1 commit into from May 19, 2020
Merged

Simplify checkIfTerminal for Windows #1088

merged 1 commit into from May 19, 2020

Commits on May 6, 2020

  1. Simplify checkIfTerminal for Windows 

    Instead of relying on EnableVirtualTerminalProcessing from
github.com/konsorten/go-windows-terminal-sequences which just calls
GetConsoleMode, sets ENABLE_VIRTUAL_TERMINAL_PROCESSING and calls
SetConsoleMode with the new modified mode, implement it directly inside
checkIfTerminal. This also avoids the duplicate call to GetConsoleMode.
    @tklauser
    tklauser committed May 6, 2020
    Copy the full SHA
    8665791 View commit details
    Browse the repository at this point in the history