Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods to FieldLogger #1013

Closed
wants to merge 1 commit into from
Closed

Conversation

tmshn
Copy link

@tmshn tmshn commented Sep 1, 2019

LogrusLogger (later renamed as FieldLogger) was introduced in #320 three years ago.

However, this interface is not updated since then; missing some methods added later.

This pr added those methods:

@tmshn
Copy link
Author

tmshn commented Sep 1, 2019

Sorry, I saw b54cafe and now understand that this is intended...the duck typing is hard... 😢

@tmshn tmshn closed this Sep 1, 2019
@tmshn tmshn reopened this Sep 1, 2019
@tmshn
Copy link
Author

tmshn commented Sep 1, 2019

Mistakenly reopened.

#872 and #987 addresses my concern, hopes v2 makes things clear

@tmshn tmshn closed this Sep 1, 2019
@tmshn tmshn deleted the expand-fieldlogger branch September 1, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant