feat: add realm to login function #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jes3rk
changed the title
sir-dunxalot
approved these changes
Apr 14, 2022
| AUTH0_SECRET="DB208FHFQJFNNA28F0N1F8SBNF8B20FBA0BXSD29SSJAGSL12D9922929D", | ||
| AUTH0_SCOPE="openid profile email", | ||
| AUTH0_SESSION_COOKIE_NAME="appSession", | ||
| AUTH0_AUDIENCE="https://lyft.auth0.com/api/v2/" |
There was a problem hiding this comment.
Thanks for cleaning this up!
| { | ||
| username, | ||
| password, | ||
| audience: Cypress.env('auth0Audience'), | ||
| scope: Cypress.env('auth0Scope'), | ||
| client_secret: Cypress.env('auth0ClientSecret'), // eslint-disable-line @typescript-eslint/camelcase | ||
| client_secret: Cypress.env('auth0ClientSecret'), // eslint-disable-line @typescript-eslint/camelcase, | ||
| realm: Cypress.env('auth0Realm') || 'Username-Password-Authentication', |
There was a problem hiding this comment.
I haven't run the tests yet, since we need to add the correct env variables but this approach seems sane to me. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Came across an issue where users created in a non-default connection could not be authorized in testing.
What I did
src/commands/get-user-tokens.jsto callauth.client.loginrather thanauth.client.loginWithDefaultDirectoryto enable specifying therealmproperty in the call.auth0Realm.How to test
cypress.env.jsonwith the new username/password and addauth0Realm: <your new connection name>