Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip write to 'name' property if not [[writable]] #2304

Merged
merged 5 commits into from Oct 28, 2020
Merged

Skip write to 'name' property if not [[writable]] #2304

merged 5 commits into from Oct 28, 2020

Commits on Oct 18, 2020

  1. Add test for sinonjs#2203

    @sjoseph7
    sjoseph7 committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    1aa75b0 View commit details
    Browse the repository at this point in the history

  2. Skip write to 'name' property if not [[writable]] 

    Resolves: sinonjs#2203
    @sjoseph7
    sjoseph7 committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    9c18996 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. fix: use context to make the test easier to read 

    Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
    @sjoseph7 @mroderick
    sjoseph7 and mroderick committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8bd06d0 View commit details
    Browse the repository at this point in the history

  2. Re-write logic for clarity 

    Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
    @sjoseph7 @mroderick
    sjoseph7 and mroderick committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    12b0d4f View commit details
    Browse the repository at this point in the history

  3. eslint

    @sjoseph7
    sjoseph7 committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ad1ccfd View commit details
    Browse the repository at this point in the history