Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo in migration 6 and updated migration docs for migration from… #2074

Merged
merged 3 commits into from Aug 26, 2019
Merged

Fix Typo in migration 6 and updated migration docs for migration from… #2074

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd7f46
Fix Typo in migration 6 and updated migration docs for migration from…
sozakir Aug 8, 2019
4fa6cc6
Fix Typo in migration 6 to 7 guide
Zaky7 Aug 26, 2019
1a7f0ec
Update migrating-to-7.0.md
fatso83 Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/migrating-to-6.0.md
View file
Open in desktop
@@ -1,7 +1,7 @@
---
layout: page
title: Migrating to v6.0 - Sinon.JS
breadcrumb: migrating to 5.0
breadcrumb: migrating to 6.0
---

There should be no reason for any code changes with the new Sinon 6. Usually, `MAJOR` releases should come with breaking changes, but there are no known breaking changes in `sinon@6` at the time of this writing. We chose to release a new major version as a [pragmatic solution to some noise related to releasing Sinon 5.1](https://github.com/sinonjs/sinon/pull/1829#issue-193284761), which featured some breaking changes related to ESM (which since has been resolved).
Expand Down
11 changes: 11 additions & 0 deletions docs/guides/migrating-to-7.0.md
View file
Open in desktop
@@ -0,0 +1,11 @@
---
layout: page
title: Migrating to v7.0 - Sinon.JS
breadcrumb: migrating to 7.0
---

For upgrading to new Sinon 7 there is no known major breaking Change except **negative ticks** are not allowed in `Sinon@7` due to update to lolex 3. So you cannot use negative values in sinon.useFakeTimers().tick();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't object to the plural, but the letter casing 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Bad I could not understand your fat Arrow Function. 😆.



If you experience any issues moving from Sinon 6 to Sinon 7, [please let us know!](https://github.com/sinonjs/sinon/issues/new?template=Bug_report.md).