Make all properties non-enumerable in spies, stubs, mocks and fakes #1975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix issue #1936 by making all properties non-enumerable in spies, stubs, mocks and fakes.
How to verify - mandatory
npm install
sinon.spy()
,sinon.stub()
,sinon.fake()
,sinon.mock()
should not return non-enumerable properties.Very few properties had to be left because removing them was breaking the tests.
Also this is a breaking change (major version) because some users might rely on spy/stub/fake/mock properties being enumerable.
CircleCI on Node 10 fails but this does not seem related to this PR, as it failed on other commits/PRs.
Checklist for author
npm run lint
passes