Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of non-cached forEach #1902

Merged
merged 2 commits into from Sep 12, 2018
Merged

Fix use of non-cached forEach #1902

merged 2 commits into from Sep 12, 2018

Conversation

mroderick
Copy link
Member

This fixes a non-cached use of forEach introduced in #1864.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mroderick mroderick mentioned this pull request Sep 12, 2018
Merged
@fatso83 fatso83 merged commit 9479130 into sinonjs:master Sep 12, 2018
@mroderick mroderick deleted the fix-use-of-foreach branch September 12, 2018 19:57
@mroderick
Copy link
Member Author

This has been published as sinon@6.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroderick @fatso83