Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds guard for empty properties in deepEqual when a matcher is provided #1901

Merged
merged 2 commits into from Sep 13, 2018
Merged

Adds guard for empty properties in deepEqual when a matcher is provided #1901

merged 2 commits into from Sep 13, 2018

Commits on Sep 11, 2018

  1. Adds guard for empty properties in deepEqual when a matcher is provided 

    In JavaScript every acts like the "for all" quantifier in mathematics.
In particular, for an empty array, it returns true. (It is vacuously
true that all elements of the empty set satisfy any given condition.)

This is not the intended behaviour for deepEqual, we should treat empty
properties as falsy.

Resolves sinonjs#1900
    @mrwillihog
    mrwillihog committed Sep 11, 2018
    Copy the full SHA
    9f6e9a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Updates issue test to use spy rather than stub

    @mrwillihog
    mrwillihog committed Sep 13, 2018
    Copy the full SHA
    c683027 View commit details
    Browse the repository at this point in the history