Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nise to 1.4.1 #1859

Closed
wants to merge 2 commits into from
Closed

Update nise to 1.4.1 #1859

wants to merge 2 commits into from

Conversation

tzrh
Copy link
Contributor

@tzrh tzrh commented Jul 11, 2018

Purpose (TL;DR) - mandatory

It would be useful to have sinonjs/nise#45 included.

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2589

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.24%

Totals Coverage Status
Change from base Build 2584: 0.0%
Covered Lines: 1965
Relevant Lines: 2019

💛 - Coveralls

@mroderick
Copy link
Member

@tzrh when you install sinon from NPM it uses the latest nise, because of the caret range: https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

$ npm install sinon@latest --save-dev

+ sinon@6.1.3
added 15 packages from 330 contributors and audited 18 packages in 3.072s
found 0 vulnerabilities

$ npm ls nise
tmp-1859@1.0.0 /Users/mroderick/tmp-1859
└─┬ sinon@6.1.3
  └── nise@1.4.2

Perhaps it is frozen in your package-lock.json / yarn.lock?

@mroderick mroderick closed this Jul 12, 2018
@tzrh
Copy link
Contributor Author

tzrh commented Jul 12, 2018

I missed that, thanks!

@tzrh tzrh deleted the patch-1 branch July 12, 2018 13:48
@tzrh
Copy link
Contributor Author

tzrh commented Jul 16, 2018

@mroderick Is it possible that nise hasn't been updated in the packaged sinon build, as happened with #1656? In http://sinonjs.org/releases/sinon-6.0.1.js, I don't see these lines.

Edit: Added this to #1861.

@mroderick
Copy link
Member

@tzrh I think you're correct!

Do you have a proposal for how we can ensure that the packaged build is done with the latest versions?

@tzrh
Copy link
Contributor Author

tzrh commented Jul 17, 2018

Adding npm update to https://github.com/sinonjs/sinon/blob/master/scripts/postversion.sh might make sense. I'm not sure if that's taking that script further away from it's original purpose though.

Edit: A check of the output for npm outdated --parseable would be less invasive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants