Reduce indentation by checking for error conditions first

Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
sinonjs · May 7, 2021 · 3c0dc46 · 3c0dc46
1 parent 39cd56d
commit 3c0dc46
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/sinon/promise.js b/lib/sinon/promise.js
@@ -56,12 +56,12 @@ function promise(executor) {
      * @param {Function} callback
      */
     function finalize(status, value, callback) {
-        if (sinonPromise.status === STATUS_PENDING) {
-            sinonPromise.status = status;
-            callback(value);
-            return;
+        if (sinonPromise.status !== STATUS_PENDING) {
+            throw new Error(`Promise already ${sinonPromise.status}`);
         }
-        throw new Error(`Promise already ${sinonPromise.status}`);
+
+        sinonPromise.status = status;
+        callback(value);
     }
 
     sinonPromise.resolve = function (value) {