Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new mochify, update dependencies, drop old node #132

Merged
merged 11 commits into from
Dec 29, 2023
Merged

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Dec 28, 2023

Purpose (TL;DR) - mandatory

  • Update all dependencies.
  • Update GitHub actions.
  • Drop node 12 and 14
  • Support node 18 and 20

Caveat

I could not use ESBuild as the mochify bundler because it ran into a dual package hazard issue with sinon.

  • Browserify looks at the browser field in package.json and decides to load ./lib/sinon.js.
  • ESBuild checks the exports and chooses the browser field from there, which points to ./pkg/sinon-esm.js.

I can override that behaviour with conditions, but then ESBuild complains that it cannot resolve assert, while Browserify will happily shim that dependency transparently.

Update: Consuming this with ESBuild doesn't work due to sinonjs/sinon#2519. Reverting this change makes it work again. ¯\(ツ)

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm run lint
  4. npm test
  5. npm run test-cloud

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ae4bd2) 100.00% compared to head (b83fd24) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          137       137           
=========================================
  Hits           137       137           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mantoni mantoni changed the title Update dependencies, drop node 12 and 14, support node 18 and 20 Use new mochify, update dependencies, drop old node Dec 29, 2023
@mantoni mantoni merged commit 1144e38 into main Dec 29, 2023
8 checks passed
@mantoni mantoni deleted the update-dependencies branch December 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants