Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: sinonFakeServer#respondWith(method, urlMatcher, body) overload #172

Merged
merged 3 commits into from May 25, 2021

Conversation

johnmiroki
Copy link
Contributor

@johnmiroki johnmiroki commented Dec 11, 2020

Feature: sinonFakeServer#respondWith(method, urlMatcher, body) where urlMatcher is a predicate. eg

function equalMatcher(requestUrl) {
    return "/hello" === requestUrl;
}

It's sort of an inplace replacement for the Regexp.
Also, it's my own feature request: sinonjs/sinon#2318

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #172 (fe9ad0b) into master (a8d1b3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          13       13           
  Lines         608      608           
=======================================
  Hits          555      555           
  Misses         53       53           
Flag Coverage Δ
unit 91.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/fake-server/index.js 97.10% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8d1b3a...fe9ad0b. Read the comment docs.

@fatso83
Copy link
Contributor

fatso83 commented May 25, 2021

I never got any feedback to my review, but I realized now I had read too quickly and did not see that the lines were unique (4 characthers were different: root vs path).

@fatso83 fatso83 merged commit cc50ae6 into sinonjs:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants