Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(runToLastAsync): Prevent infinite loop #451

Merged
merged 2 commits into from Nov 21, 2022
Merged

Fix(runToLastAsync): Prevent infinite loop #451

merged 2 commits into from Nov 21, 2022

Conversation

guillaumeduboc
Copy link
Contributor

Purpose (TL;DR) - mandatory

Fix #450
In the runToLastAsync method, wait the correct amount of time with tickAsync

@guillaumeduboc guillaumeduboc mentioned this pull request Nov 19, 2022
Merged
fatso83
fatso83 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the diff <3 Thanks for taking the time!

@fatso83
Copy link
Contributor

fatso83 commented Nov 21, 2022 •
edited

Ah, the tests fail on Node 18, meaning #441 is blocking this and others.
image

@fatso83 fatso83 merged commit bb28fea into sinonjs:main Nov 21, 2022
@guillaumeduboc guillaumeduboc deleted the fix/issue-450/runToLastAsync-infinite-loop branch January 17, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatso83 fatso83 fatso83 approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runToLastAsync doing infinite loop when now is specified to setup clock
3 participants
@guillaumeduboc @fatso83 @benjamingr