-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix global performance node 16 #412
Conversation
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 94.29% 94.17% -0.12%
==========================================
Files 1 1
Lines 613 618 +5
==========================================
+ Hits 578 582 +4
- Misses 35 36 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big <3 for this. Just a question before merging.
Let's merge and open another PR to discuss versioning? |
I am merging and ignoring the codecov failures due to dropped coverage, but it would be good if that was analyzed somehow so that we understand why. I am guessing the various "if x is present, run this, else that" is only covered if the tests are run in several runtimes (which it is), but are the codecov results just one of these runs or the aggregated result? If the former, then it's hard to do something about it, and if the latter, it is weird that we get a drop. |
* Immediately return after this.skip() Ref #412 (comment) * Update browser list
FWIW for future readers: using fake-timers@9.1.2 (via jest) with nodejs 16.3.0: jest.useFakeTimers({
now: ...
}); I still have
Solution: either upgrade to nodejs 16.5.0+, or use jest.useFakeTimers({
now: ...
doNotFake: ['performance'],
}); |
Purpose (TL;DR) - mandatory
Fixes
performance
on Node 16 which has a globalperformance
but not a globalPerformance
cc @fatso83 @SimenB @itayperry