New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gem versions #2

Merged

River-Ye merged 2 commits into master from river-upgrade-gem-versions

May 17, 2023

Contributor

River-Ye commented May 17, 2023 •

edited

說明:

因原本 Gemfile 有指定 rubocop 版本，並不支援 Ruby 3.1 以上，故將 Gemfile 的 gem 升級到最新，支援到最新 3.2 (Support TargetRubyVersion 3.2 (experimental) rubocop/rubocop#10433)
將 Dockerfile 的 ruby base 升級到最新 Ruby 3.2.2，在 ARM 架構 (ex: M1/M2 晶片) 已能直接使用，故將 Dockerfile.arm64 檔案刪除
從 wms 準備升級 Ruby 到 3.1 時，CI 噴錯發現的 https://drone.sinlead.com/sinlead/wms/17145/6/3
wms PR: https://github.com/sinlead/wms/pull/4379

截圖 2023-05-17 上午10 12 23

確認沒問題後，才會推新的 image 版本到 docker hub，預計要下的 code

$ docker buildx build --platform linux/amd64,linux/arm64 -t sinlead/drone-pronto:v1.3.0 --push .

Local 測試

在這支 branch 先 build image ($ docker build .)
接著在 wms branch 跑該 image 檢查

$ docker images
$ git fetch origin master && docker run --rm -v $PWD:/data -w /data c1869630581e pronto run -c origin/master --exit-code

River-Ye added 2 commits

May 17, 2023 09:59


          Upgrade gems versions

c08fd82


          Supports arm architecture

8618e3c

River-Ye requested review from MickPlaYer and spy1031

May 17, 2023 02:23

MickPlaYer approved these changes

View reviewed changes

River-Ye merged commit 1688523 into master

River-Ye deleted the river-upgrade-gem-versions branch

May 17, 2023 04:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment