fix: define package.json export #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried this fix and it didn't work for me. I instead deleted the "exports" config and fixed my own type issues within my project it worked. Edit** I went in and compiled single-spa-react on its own and it seemed to work. Idk |
courtyenn
added a commit
to courtyenn/single-spa-react
that referenced
this pull request
May 22, 2023
|
@darshkpatel do you know the solution to this typescript problem? |
|
I’ll investigate
…On Wed, 28 Jun 2023 at 5:12 AM, Joel Denning ***@***.***> wrote:
@darshkpatel <https://github.com/darshkpatel> do you know the solution to
this typescript problem?
#168 <#168>
—
Reply to this email directly, view it on GitHub
<#168 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACV4TLSH5EMA2APT642Q7ZTXNNVXDANCNFSM6AAAAAAXYW3A7I>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiling a react application using a rollup based plugin (@vitejs/plugin-react in my case) will throw an error if package.json isn't exported.
The only package failing in my usecase is
single-spa-reactI did test this change by manually adding this line to the package in the node_modules folder and compiling again.Example of such a export: https://github.com/facebook/react/blob/16d053d592673dd5565d85109f259371b23f87e8/packages/react-refresh/package.json#L24
Related issue on another repo:
uuidjs/uuid#444
Fixes: #140