fix: Encode fragmentIdentifier with encodeURI method not encodeURICom…

…ponent at stringifyUrl
sindresorhus · Dec 4, 2022 · 1d24ce0 · 1d24ce0
1 parent 5beef41
commit 1d24ce0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -222,7 +222,15 @@ function validateArrayFormatSeparator(value) {
 
 function encode(value, options) {
 	if (options.encode) {
-		return options.strict ? strictUriEncode(value) : encodeURIComponent(value);
+		if (options[encodeFragmentIdentifier]) {
+			return encodeURI(value);
+		}
+
+		if (options.strict) {
+			return strictUriEncode(value);
+		}
+
+		return encodeURIComponent(value);
 	}
 
 	return value;

diff --git a/test/stringify-url.js b/test/stringify-url.js
@@ -26,6 +26,7 @@ test('stringify URL with fragment identifier', t => {
 	t.deepEqual(queryString.stringifyUrl({url: 'https://foo.bar/#abc', query: {}, fragmentIdentifier: 'top'}), 'https://foo.bar/#top');
 	t.deepEqual(queryString.stringifyUrl({url: 'https://foo.bar', query: {}}), 'https://foo.bar');
 	t.deepEqual(queryString.stringifyUrl({url: 'https://foo.bar', query: {}, fragmentIdentifier: 'foo bar'}), 'https://foo.bar#foo%20bar');
+	t.deepEqual(queryString.stringifyUrl({url: 'https://foo.bar/', query: {}, fragmentIdentifier: '/foo/bar'}), 'https://foo.bar/#/foo/bar');
 });
 
 test('skipEmptyString:: stringify URL with a query string', t => {