Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for multiple mapper errors with stop on error #49

Merged
merged 7 commits into from Oct 3, 2021
Merged

Add test cases for multiple mapper errors with stop on error #49

merged 7 commits into from Oct 3, 2021

Commits on Oct 2, 2021

  1. Add (failing) test case for multiple mapper errors with stop on error 

    - Add a failing test case to indicate that only 1 of the mapper errors is catchable when stop on error is true and many mappers throw an exception
- With concurrent mappers it seems that exceptions should throw an AggregateError when stop on error is true and more than 1 concurrent mapper throws - the iteration of new input items should stop immediately, but all invoked mappers need to finish and all of their exceptions should be bundled and rejected at once - maybe?
    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    081d990 View commit details
    Browse the repository at this point in the history

  2. Remove extra line at end

    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    5f781d9 View commit details
    Browse the repository at this point in the history

  3. Expect the 1st item to throw

    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    b1690f7 View commit details
    Browse the repository at this point in the history

  4. Add Readme note about stopOnError

    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    de7de0c View commit details
    Browse the repository at this point in the history

  5. Implement suggested changes 

    - Note: the doc note is now ~25% shorter
    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    3cf8469 View commit details
    Browse the repository at this point in the history

  6. One more suggestion

    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    3cb5885 View commit details
    Browse the repository at this point in the history

  7. Fix lint

    @huntharo
    huntharo committed Oct 2, 2021
    Copy the full SHA
    e8ba400 View commit details
    Browse the repository at this point in the history