Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent some potential unhandled exceptions #48

Merged
merged 4 commits into from Sep 11, 2021
Merged

Prevent some potential unhandled exceptions #48

merged 4 commits into from Sep 11, 2021

Commits on Sep 7, 2021

  1. Add test cases for source iterator exceptions 

    - Source iterator next() functions can throw
- There are 3 distinct cases where next() is called, one of which does not have a try/catch around it that will reject the outer promise, resulting in an unhandled promise rejection
    @huntharo
    huntharo committed Sep 7, 2021
    Copy the full SHA
    d160672 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Catch iteratable.next() exceptions and reject promise

    @huntharo
    huntharo committed Sep 11, 2021
    Copy the full SHA
    bc5f1c0 View commit details
    Browse the repository at this point in the history

  2. Fix build error and change requests

    @huntharo
    huntharo committed Sep 11, 2021
    Copy the full SHA
    863f2b7 View commit details
    Browse the repository at this point in the history

  3. Fix change request

    @huntharo
    huntharo committed Sep 11, 2021
    Copy the full SHA
    bf4c25b View commit details
    Browse the repository at this point in the history