Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of the .clear() method #182

Merged
merged 3 commits into from Aug 23, 2021
Merged

Improve performance of the .clear() method #182

merged 3 commits into from Aug 23, 2021

Commits on Aug 15, 2021

  1. indent-issue test now passes 

    changes:
- including spinner.indent in the calculation of lineCount

- calling updateLineCount in indent setter
    @moofoo @G-Rath
    moofoo authored and G-Rath committed Aug 15, 2021
    Copy the full SHA
    f8d53a7 View commit details
    Browse the repository at this point in the history

  2. Improvements to clear method 

    - cursorTo is called the minimal number of times necessary: to set the cursor position to the start of the line to set up the clearLine(1) loop, and after the loop to reset the cursor (if necessary)

- clearLine(0) and clearLine(-1) cause flickering issues in Windows terminals when executed on an interval. Using clearLine(1) resolves that issue.
    @moofoo @G-Rath
    moofoo authored and G-Rath committed Aug 15, 2021
    Copy the full SHA
    198e067 View commit details
    Browse the repository at this point in the history

  3. test: cherry-pick cases for new clearing logic

    @G-Rath
    G-Rath committed Aug 15, 2021
    Copy the full SHA
    69870d6 View commit details
    Browse the repository at this point in the history