Improvement performance of the .clear() method
#171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - including spinner.indent in the calculation of lineCount - calling updateLineCount in indent setter
- cursorTo is called the minimal number of times necessary: to set the cursor position to the start of the line to set up the clearLine(1) loop, and after the loop to reset the cursor (if necessary) - clearLine(0) and clearLine(-1) cause flickering issues in Windows terminals when executed on an interval. Using clearLine(1) resolves that issue.
Could you include the tests in this PR? |
sindresorhus
changed the title
.clear() method
|
Will this fix WSL flickering issue? |
|
Is there any reason this hasn't been merged, @sindresorhus? It makes a huge difference on the windows systems I have tried and seemingly all tests have passed? |
|
I applied this locally and found it completely eliminates the minor flicker I'd observed when developing my cli app, so would love to help get this landed. @sindresorhus I've got an updated version of this branch with the tests from the linked commit cherry-picked in, with everything passing - is there more work you'd like done before landing this, or should I go ahead with creating a PR? |
|
@G-Rath Go ahead with the PR. |
|
Have created #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursorTo is called the minimal number of times necessary: to set the cursor position to the start of the line to set up the clearLine(1) loop, and after the loop to reset the cursor (if necessary)
clearLine(0) and clearLine(-1) cause flickering issues in Windows terminals when executed on an interval. Using clearLine(1) resolves this issue.
Tests can be found here