Fix passed an illegal parameter #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,7 +202,7 @@ const baseOpen = async options => { | |||
| } | |||
|
|
|||
| if (appArguments.length > 0) { | |||
| appArguments = appArguments.map(arg => `"\`"${arg}\`""`); | |||
There was a problem hiding this comment.
It's double-quoted for a reason. You will have to prove why it's incorrect.
// Double quote with double quotes to ensure the inner quotes are passed through.
// Inner quotes are delimited for PowerShell interpretation with backticks.
|
// @tim-stasse |
|
Hi, I am making this request because I am using mstsc and below is my code. import { openApp } from 'open';
const params = ['test.rdp','/v','127.0.0.1:3389']
openApp('mstsc.exe', { arguments: params });When I execute this code, mstsc doesn't work.
After I remove the extra quotes, openApp will work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, if I pass parameters to openApp, the program will not recognize it, and it will work normally after removing the extra quotes.