Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #236. Additional option "hiddenTerminal" #238

Closed
wants to merge 1 commit into from

Conversation

kykint
Copy link
Contributor

@kykint kykint commented Mar 21, 2021

No description provided.

@sindresorhus
Copy link
Owner

I don't add options lightly. Please explain why the behavior happens in the first place. If there's a way to solve this without an option, I would prefer that.

@qm3ster
Copy link

qm3ster commented Apr 15, 2021

Sure seemed like this 👉 #235 👈 option in the call to powershell was added lightly 😉
What happens is that running powershell.exe –WindowStyle Hidden from a terminal, where a new Powershell window wouldn't spawn anyway, instead reconfigures the window of the host to making it invisible. The same happens even if nodejs is a middleman.

This is a very confusing behavior, and for a while both the person that asked for my help with this issue and the creator of #236 thought the host is being terminated.

@sindresorhus
Copy link
Owner

Alright, PR welcome to revert that commit then.

@qm3ster
Copy link

qm3ster commented Apr 18, 2021

But then a PowerShell window will pop up and scare the users when used from a graphical application binary.

@met583
Copy link

met583 commented Apr 29, 2021

what steps should i take to prevent the terminal from being hidden? Fix (lookup)?

@qm3ster
Copy link

qm3ster commented Apr 29, 2021

@met583 you can use "open": "8.0.2" (not "open": "^8.0.2" or "open": "8.0.5") until this is merged.
You can achieve that with npm i -E open@8.0.2 (-E for "exact")

@met583
Copy link

met583 commented Apr 30, 2021

@ met583 puoi usare "open": "8.0.2"(not "open": "^8.0.2"or "open": "8.0.5") fino a quando non viene unito.
Puoi ottenerlo con npm i -E open@8.0.2( -Eper "esatto")

Thanks, where should I enter that command? In the cdm "open" is not recognized as an internal or external command. How do I proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants