Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta tweaks #233

Merged
merged 3 commits into from Mar 3, 2021
Merged

Meta tweaks #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c7ef6f
Update index.d.ts
Richienb Mar 3, 2021
dc2c314
Update readme.md
Richienb Mar 3, 2021
ec49fb4
Update readme.md
Richienb Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Expand Up @@ -94,7 +94,7 @@ declare const open: {
await open('https://sindresorhus.com', {app: {name: 'firefox'}});

// Specify app arguments.
await open('https://sindresorhus.com', {app: {name: 'google chrome', arguments: '--incognito'}});
await open('https://sindresorhus.com', {app: {name: 'google chrome', arguments: ['--incognito']}});
```
*/
(
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ Note: The original [`open` package](https://github.com/pwnall/node-open) was pre
- Actively maintained.
- Supports app arguments.
- Safer as it uses `spawn` instead of `exec`.
- Fixes most of the open original `node-open` issues.
- Fixes most of the original `node-open` issues.
- Includes the latest [`xdg-open` script](https://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=c55122295c2a480fa721a9614f0e2d42b2949c18) for Linux.
- Supports WSL paths to Windows apps.

Expand All @@ -39,7 +39,7 @@ await open('https://sindresorhus.com');
await open('https://sindresorhus.com', {app: {name: 'firefox'}});

// Specify app arguments.
await open('https://sindresorhus.com', {app: {name: 'google chrome', arguments: '--incognito'}});
await open('https://sindresorhus.com', {app: {name: 'google chrome', arguments: ['--incognito']}});
```

## API
Expand Down