Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the system xdg-open on Linux when open is bundled/packaged #134

Merged
merged 4 commits into from May 12, 2019
Merged

Use the system xdg-open on Linux when open is bundled/packaged #134

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a09e31
Fixes #133 use /xdg-open when packaged
marcellourbani May 11, 2019
fce18b9
Fixes #133 use /xdg-open when packaged - commented
marcellourbani May 11, 2019
7fb93ea
Fixes #133 use /xdg-open when packaged - fix code formatting
marcellourbani May 11, 2019
8d21905
Update index.js
sindresorhus May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion index.js
View file
Open in desktop
Expand Up @@ -73,7 +73,10 @@ module.exports = async (target, options) => {
if (options.app) {
command = options.app;
} else {
const useSystemXdgOpen = process.versions.electron || process.platform === 'android';
// When bundled by Webpack, there's no actual package file path and no local `xdg-open`.
const isBundled = !__dirname || __dirname === '/';

const useSystemXdgOpen = process.versions.electron || process.platform === 'android' || isBundled;
command = useSystemXdgOpen ? 'xdg-open' : path.join(__dirname, 'xdg-open');
}

Expand Down