fix: npm 10 bug with npm pack; issue 740 #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open an issue or link to an existing npm issue about this as a code comment? I would like to be able to eventually remove that workaround. |
2 tasks
|
Looks like this is the corresponding issue to track for |
|
|
Ahhh missed that. Done 😃 |
|
Random sidenote: Reminds the that this would be awesome: sindresorhus/eslint-plugin-unicorn#1858 (comment) |
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740
Anyone using
npwith newer versions of Node.js andnpm >= 10is probably running into this issue. This PR just sanitizes thestdoutfromnpm packto look for the first[character to start parsing the output JSON array, which should be backwards compatible with previous functionality.