Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn berry support #723

Merged
merged 21 commits into from
Dec 5, 2023
Merged

Yarn berry support #723

merged 21 commits into from
Dec 5, 2023

Conversation

mifi
Copy link
Sponsor Contributor

@mifi mifi commented Dec 5, 2023 •
edited

I will maintain this functionality in the future :)
let me know if you'd like something to be implemented differently.

#612

@mifi
fix import bug
0c7bdcf 
enable2fa.getEnable2faArgs is not a function

probably from rewriting to esm
@mifi
don't exit with 0 even though it failed
846a0b3 
can be reproduced by running `np` without an internet connection
thereby it thinks that options.availability.isUnknown but the package is not scoped,
so it just exits with success (exit code 0)
@mifi
fix bug
4bf6ae0 
where it was trying to call setFrom with the first argument as a Version instance
instead of a string
causing code to fail
@mifi
allow publishing scoped packages
0bd4e93 
otherwise it fails with:
Response Code: 402 (Payment Required)
You must sign up for private packages
@mifi
fix lint and test
773bd1d
@mifi
add bool specification for cli option
7566a3f
@mifi
implement yarn berry support
83a15eb 
tests not yet fixed
@mifi
add note about scoped packages
11c02b7
@mifi
add note about pnpm too
0901b9b
@mifi
reverse publishScoped arg
e999583
@mifi
Merge branch 'improvements' into yarn-berry
d95a38e 
# Conflicts:
#	readme.md
@mifi
add ci env
0fb0845
@mifi
Merge branch 'main' into yarn-berry
086ad00 
# Conflicts:
#	readme.md
@mifi
run xo --fix
614869f
@mifi
revert
145cdda
@mifi
fixes and tests
0f9184e
sindresorhus
sindresorhus requested changes Dec 5, 2023
View reviewed changes
source/ui.js Outdated Show resolved Hide resolved
source/ui.js Outdated Show resolved Hide resolved
source/ui.js Outdated Show resolved Hide resolved
source/npm/handle-npm-error.js Outdated Show resolved Hide resolved
source/npm/handle-npm-error.js Show resolved Hide resolved
source/index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Make sure you manually test without Yarn too, to make sure nothing broke.

@mifi
Copy link
Sponsor Contributor Author

mifi commented Dec 5, 2023

i just tested a publish maunally with yarn4 and npm 9

@sindresorhus sindresorhus merged commit 0d9522b into sindresorhus:main Dec 5, 2023
1 check passed
@sindresorhus
Copy link
Owner

Thanks :)

Vylpes pushed a commit to Vylpes/card-drop that referenced this pull request Dec 25, 2023
@Vylpes
Update dependency np to v9 (#123)
82941d4 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [np](https://github.com/sindresorhus/np) | devDependencies | major | [`^8.0.4` -> `^9.0.0`](https://renovatebot.com/diffs/npm/np/8.0.4/9.2.0) |

---

### Release Notes

<details>
<summary>sindresorhus/np (np)</summary>

### [`v9.2.0`](https://github.com/sindresorhus/np/releases/tag/v9.2.0)

[Compare Source](sindresorhus/np@v9.1.0...v9.2.0)

-   Fix yarn npm publish for scoped packages  [`8d3a984`](sindresorhus/np@8d3a984)
-   Fix broken revert code after publish failure  [`819ed29`](sindresorhus/np@819ed29)

### [`v9.1.0`](https://github.com/sindresorhus/np/releases/tag/v9.1.0)

[Compare Source](sindresorhus/np@v9.0.0...v9.1.0)

-   Add Yarn Berry support ([#&#8203;723](sindresorhus/np#723))  [`0d9522b`](sindresorhus/np@0d9522b)

### [`v9.0.0`](https://github.com/sindresorhus/np/releases/tag/v9.0.0)

[Compare Source](sindresorhus/np@v8.0.4...v9.0.0)

##### Breaking

-   Require Node.js 18 and npm 9  [`6c2e00e`](sindresorhus/np@6c2e00e)

##### Improvements

-   Group unpublished files in folders ([#&#8203;716](sindresorhus/np#716))  [`c31c2bc`](sindresorhus/np@c31c2bc)
-   improve messages related to new files and dependencies ([#&#8203;702](sindresorhus/np#702))  [`ad7b09e`](sindresorhus/np@ad7b09e)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://gitea.vylpes.xyz/External/card-drop/pulls/123
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Vylpes pushed a commit to Vylpes/random-bunny that referenced this pull request Jan 16, 2024
@Vylpes
Update dependency np to v9 (#135)
8c440c0 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [np](https://github.com/sindresorhus/np) | devDependencies | major | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/np/8.0.4/9.2.0) |

---

### Release Notes

<details>
<summary>sindresorhus/np (np)</summary>

### [`v9.2.0`](https://github.com/sindresorhus/np/releases/tag/v9.2.0)

[Compare Source](sindresorhus/np@v9.1.0...v9.2.0)

-   Fix yarn npm publish for scoped packages  [`8d3a984`](sindresorhus/np@8d3a984)
-   Fix broken revert code after publish failure  [`819ed29`](sindresorhus/np@819ed29)

### [`v9.1.0`](https://github.com/sindresorhus/np/releases/tag/v9.1.0)

[Compare Source](sindresorhus/np@v9.0.0...v9.1.0)

-   Add Yarn Berry support ([#&#8203;723](sindresorhus/np#723))  [`0d9522b`](sindresorhus/np@0d9522b)

### [`v9.0.0`](https://github.com/sindresorhus/np/releases/tag/v9.0.0)

[Compare Source](sindresorhus/np@v8.0.4...v9.0.0)

##### Breaking

-   Require Node.js 18 and npm 9  [`6c2e00e`](sindresorhus/np@6c2e00e)

##### Improvements

-   Group unpublished files in folders ([#&#8203;716](sindresorhus/np#716))  [`c31c2bc`](sindresorhus/np@c31c2bc)
-   improve messages related to new files and dependencies ([#&#8203;702](sindresorhus/np#702))  [`ad7b09e`](sindresorhus/np@ad7b09e)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/135
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Vylpes pushed a commit to Vylpes/vylbot-app that referenced this pull request Jan 22, 2024
@Vylpes
Update dependency np to v9 (#380)
f0ab3b9 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [np](https://github.com/sindresorhus/np) | devDependencies | major | [`^8.0.4` -> `^9.0.0`](https://renovatebot.com/diffs/npm/np/8.0.4/9.2.0) |

---

### Release Notes

<details>
<summary>sindresorhus/np (np)</summary>

### [`v9.2.0`](https://github.com/sindresorhus/np/releases/tag/v9.2.0)

[Compare Source](sindresorhus/np@v9.1.0...v9.2.0)

-   Fix yarn npm publish for scoped packages  [`8d3a984`](sindresorhus/np@8d3a984)
-   Fix broken revert code after publish failure  [`819ed29`](sindresorhus/np@819ed29)

### [`v9.1.0`](https://github.com/sindresorhus/np/releases/tag/v9.1.0)

[Compare Source](sindresorhus/np@v9.0.0...v9.1.0)

-   Add Yarn Berry support ([#&#8203;723](sindresorhus/np#723))  [`0d9522b`](sindresorhus/np@0d9522b)

### [`v9.0.0`](https://github.com/sindresorhus/np/releases/tag/v9.0.0)

[Compare Source](sindresorhus/np@v8.0.4...v9.0.0)

##### Breaking

-   Require Node.js 18 and npm 9  [`6c2e00e`](sindresorhus/np@6c2e00e)

##### Improvements

-   Group unpublished files in folders ([#&#8203;716](sindresorhus/np#716))  [`c31c2bc`](sindresorhus/np@c31c2bc)
-   improve messages related to new files and dependencies ([#&#8203;702](sindresorhus/np#702))  [`ad7b09e`](sindresorhus/np@ad7b09e)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->

Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/vylbot-app/pulls/380
Reviewed-by: Vylpes <ethan@vylpes.com>
Co-authored-by: Renovate Bot <renovate@vylpes.com>
Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mifi @sindresorhus