Improvements and fixes #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable2fa.getEnable2faArgs is not a function probably from rewriting to esm
can be reproduced by running `np` without an internet connection thereby it thinks that options.availability.isUnknown but the package is not scoped, so it just exits with success (exit code 0)
otherwise it fails with: Response Code: 402 (Payment Required) You must sign up for private packages
sindresorhus
requested changes
Nov 11, 2023
Sorry, no interest. I don't want more code-paths to maintain. Everyone wants their feature supported, but no one stays around in the long-term to fix bugs. |
|
I have now reverted the |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs and allow publishing scoped packages (to avoid 402 error). Actually these are all bugs I discovered while working on support for yarn berry in
np.I realize that you're not interested in supporting yarn berry #612 - however I use it a lot and I use np as well, so I figured I'd try to add support for it. I can submit a separate PR for berry support, but if you're still not interested I'll publish a fork of
npinstead. Here's the branch: mifi#1for easier review, see each commit separately.