Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm access error(#665) #666

Merged
merged 18 commits into from Dec 27, 2022
Merged

Fix npm access error(#665) #666

Changes from 2 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7637a80
Update util.js
DerTimonius Nov 15, 2022
5102bdb
Fix npm access error
DerTimonius Nov 15, 2022
2b4cf8b
Fix npm access subcommands in tests
Nov 16, 2022
9853c16
Update prerequisite-tasks.js
DerTimonius Nov 16, 2022
1223221
Fix npm access subcommands
DerTimonius Nov 16, 2022
0f5af26
Merge pull request #1 from DerTimonius/fix-tests
DerTimonius Nov 16, 2022
14e7788
Add "--json" flag
DerTimonius Nov 18, 2022
a274b88
Merge branch 'main' of https://github.com/DerTimonius/np
Nov 21, 2022
e0f2564
Add --json flag to tests
Nov 21, 2022
abfeed0
Add --json flag to tests
DerTimonius Nov 21, 2022
888bc2c
Add checks for npm version
Nov 23, 2022
bafec2a
Merge branch 'main' into new-tests
DerTimonius Nov 23, 2022
a6502c5
Merge pull request #2 from DerTimonius/new-tests
DerTimonius Nov 23, 2022
0744f21
Change npm version check to semver
Nov 23, 2022
98bd236
Merge branch 'main' of https://github.com/DerTimonius/np
Nov 23, 2022
7ab1b63
Remove --json flag on older npm versions
Nov 25, 2022
6d4f036
Move location of --json flag
Nov 25, 2022
5d2db24
Move --json flag to end of argument
DerTimonius Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/npm/util.js
View file
Open in desktop
Expand Up @@ -68,13 +68,13 @@ exports.collaborators = async pkg => {
const packageName = pkg.name;
ow(packageName, ow.string);

const args = ['access', 'ls-collaborators', packageName];
const args = [packageName];
if (exports.isExternalRegistry(pkg)) {
args.push('--registry', pkg.publishConfig.registry);
}

try {
const {stdout} = await execa('npm', args);
const {stdout} = await execa('npm access list collaborators', args);
sindresorhus marked this conversation as resolved.
Show resolved Hide resolved
return stdout;
} catch (error) {
// Ignore non-existing package error
Expand Down