New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer local install #572
Merged
sindresorhus
merged 5 commits into
sindresorhus:master
from
jamestalmage:pass-to-local-install
Oct 29, 2020
Merged
Prefer local install #572
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| #!/usr/bin/env node | ||
| 'use strict'; | ||
| // eslint-disable-next-line import/no-unassigned-import | ||
| require('symbol-observable'); // Important: This needs to be first to prevent weird Observable incompatibilities | ||
| const logSymbols = require('log-symbols'); | ||
| const meow = require('meow'); | ||
| const updateNotifier = require('update-notifier'); | ||
| const hasYarn = require('has-yarn'); | ||
| const config = require('./config'); | ||
| const {isPackageNameAvailable} = require('./npm/util'); | ||
| const version = require('./version'); | ||
| const util = require('./util'); | ||
| const ui = require('./ui'); | ||
| const np = require('.'); | ||
|
|
||
| const cli = meow(` | ||
| Usage | ||
| $ np <version> | ||
|
|
||
| Version can be: | ||
| ${version.SEMVER_INCREMENTS.join(' | ')} | 1.2.3 | ||
|
|
||
| Options | ||
| --any-branch Allow publishing from any branch | ||
| --branch Name of the release branch (default: master) | ||
| --no-cleanup Skips cleanup of node_modules | ||
| --no-tests Skips tests | ||
| --yolo Skips cleanup and testing | ||
| --no-publish Skips publishing | ||
| --preview Show tasks without actually executing them | ||
| --tag Publish under a given dist-tag | ||
| --no-yarn Don't use Yarn | ||
| --contents Subdirectory to publish | ||
| --no-release-draft Skips opening a GitHub release draft | ||
| --test-script Name of npm run script to run tests before publishing (default: test) | ||
| --no-2fa Don't enable 2FA on new packages (not recommended) | ||
|
|
||
| Examples | ||
| $ np | ||
| $ np patch | ||
| $ np 1.0.2 | ||
| $ np 1.0.2-beta.3 --tag=beta | ||
| $ np 1.0.2-beta.3 --tag=beta --contents=dist | ||
| `, { | ||
| booleanDefault: undefined, | ||
| flags: { | ||
| anyBranch: { | ||
| type: 'boolean' | ||
| }, | ||
| branch: { | ||
| type: 'string' | ||
| }, | ||
| cleanup: { | ||
| type: 'boolean' | ||
| }, | ||
| tests: { | ||
| type: 'boolean' | ||
| }, | ||
| yolo: { | ||
| type: 'boolean' | ||
| }, | ||
| publish: { | ||
| type: 'boolean' | ||
| }, | ||
| releaseDraft: { | ||
| type: 'boolean' | ||
| }, | ||
| tag: { | ||
| type: 'string' | ||
| }, | ||
| yarn: { | ||
| type: 'boolean' | ||
| }, | ||
| contents: { | ||
| type: 'string' | ||
| }, | ||
| preview: { | ||
| type: 'boolean' | ||
| }, | ||
| testScript: { | ||
| type: 'string' | ||
| }, | ||
| '2fa': { | ||
| type: 'boolean' | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| updateNotifier({pkg: cli.pkg}).notify(); | ||
|
|
||
| (async () => { | ||
| const pkg = util.readPkg(); | ||
|
|
||
| const defaultFlags = { | ||
| cleanup: true, | ||
| tests: true, | ||
| publish: true, | ||
| releaseDraft: true, | ||
| yarn: hasYarn(), | ||
| '2fa': true | ||
| }; | ||
|
|
||
| const localConfig = await config(); | ||
|
|
||
| const flags = { | ||
| ...defaultFlags, | ||
| ...localConfig, | ||
| ...cli.flags | ||
| }; | ||
|
|
||
| // Workaround for unintended auto-casing behavior from `meow`. | ||
| if ('2Fa' in flags) { | ||
| flags['2fa'] = flags['2Fa']; | ||
| } | ||
|
|
||
| const runPublish = flags.publish && !pkg.private; | ||
|
|
||
| const availability = flags.publish ? await isPackageNameAvailable(pkg) : { | ||
| isAvailable: false, | ||
| isUnknown: false | ||
| }; | ||
|
|
||
| const version = cli.input.length > 0 ? cli.input[0] : false; | ||
|
|
||
| const options = await ui({ | ||
| ...flags, | ||
| availability, | ||
| version, | ||
| runPublish | ||
| }, pkg); | ||
|
|
||
| if (!options.confirm) { | ||
| process.exit(0); | ||
| } | ||
|
|
||
| console.log(); // Prints a newline for readability | ||
| const newPkg = await np(options.version, options); | ||
|
|
||
| if (options.preview) { | ||
| return; | ||
| } | ||
|
|
||
| console.log(`\n ${newPkg.name} ${newPkg.version} published 🎉`); | ||
| })().catch(error => { | ||
| console.error(`\n${logSymbols.error} ${error.message}`); | ||
| process.exit(1); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,147 +1,14 @@ | ||
| #!/usr/bin/env node | ||
| 'use strict'; | ||
| // eslint-disable-next-line import/no-unassigned-import | ||
| require('symbol-observable'); // Important: This needs to be first to prevent weird Observable incompatibilities | ||
| const logSymbols = require('log-symbols'); | ||
| const meow = require('meow'); | ||
| const updateNotifier = require('update-notifier'); | ||
| const hasYarn = require('has-yarn'); | ||
| const config = require('./config'); | ||
| const {isPackageNameAvailable} = require('./npm/util'); | ||
| const version = require('./version'); | ||
| const util = require('./util'); | ||
| const ui = require('./ui'); | ||
| const np = require('.'); | ||
| const importLocal = require('import-local'); | ||
| const isInstalledGlobally = require('is-installed-globally'); | ||
|
|
||
| const cli = meow(` | ||
| Usage | ||
| $ np <version> | ||
|
|
||
| Version can be: | ||
| ${version.SEMVER_INCREMENTS.join(' | ')} | 1.2.3 | ||
|
|
||
| Options | ||
| --any-branch Allow publishing from any branch | ||
| --branch Name of the release branch (default: master) | ||
| --no-cleanup Skips cleanup of node_modules | ||
| --no-tests Skips tests | ||
| --yolo Skips cleanup and testing | ||
| --no-publish Skips publishing | ||
| --preview Show tasks without actually executing them | ||
| --tag Publish under a given dist-tag | ||
| --no-yarn Don't use Yarn | ||
| --contents Subdirectory to publish | ||
| --no-release-draft Skips opening a GitHub release draft | ||
| --test-script Name of npm run script to run tests before publishing (default: test) | ||
| --no-2fa Don't enable 2FA on new packages (not recommended) | ||
|
|
||
| Examples | ||
| $ np | ||
| $ np patch | ||
| $ np 1.0.2 | ||
| $ np 1.0.2-beta.3 --tag=beta | ||
| $ np 1.0.2-beta.3 --tag=beta --contents=dist | ||
| `, { | ||
| booleanDefault: undefined, | ||
| flags: { | ||
| anyBranch: { | ||
| type: 'boolean' | ||
| }, | ||
| branch: { | ||
| type: 'string' | ||
| }, | ||
| cleanup: { | ||
| type: 'boolean' | ||
| }, | ||
| tests: { | ||
| type: 'boolean' | ||
| }, | ||
| yolo: { | ||
| type: 'boolean' | ||
| }, | ||
| publish: { | ||
| type: 'boolean' | ||
| }, | ||
| releaseDraft: { | ||
| type: 'boolean' | ||
| }, | ||
| tag: { | ||
| type: 'string' | ||
| }, | ||
| yarn: { | ||
| type: 'boolean' | ||
| }, | ||
| contents: { | ||
| type: 'string' | ||
| }, | ||
| preview: { | ||
| type: 'boolean' | ||
| }, | ||
| testScript: { | ||
| type: 'string' | ||
| }, | ||
| '2fa': { | ||
| type: 'boolean' | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| updateNotifier({pkg: cli.pkg}).notify(); | ||
|
|
||
| (async () => { | ||
| const pkg = util.readPkg(); | ||
|
|
||
| const defaultFlags = { | ||
| cleanup: true, | ||
| tests: true, | ||
| publish: true, | ||
| releaseDraft: true, | ||
| yarn: hasYarn(), | ||
| '2fa': true | ||
| }; | ||
|
|
||
| const localConfig = await config(); | ||
|
|
||
| const flags = { | ||
| ...defaultFlags, | ||
| ...localConfig, | ||
| ...cli.flags | ||
| }; | ||
|
|
||
| // Workaround for unintended auto-casing behavior from `meow`. | ||
| if ('2Fa' in flags) { | ||
| flags['2fa'] = flags['2Fa']; | ||
| } | ||
|
|
||
| const runPublish = flags.publish && !pkg.private; | ||
|
|
||
| const availability = flags.publish ? await isPackageNameAvailable(pkg) : { | ||
| isAvailable: false, | ||
| isUnknown: false | ||
| }; | ||
|
|
||
| const version = cli.input.length > 0 ? cli.input[0] : false; | ||
|
|
||
| const options = await ui({ | ||
| ...flags, | ||
| availability, | ||
| version, | ||
| runPublish | ||
| }, pkg); | ||
|
|
||
| if (!options.confirm) { | ||
| process.exit(0); | ||
| } | ||
|
|
||
| console.log(); // Prints a newline for readability | ||
| const newPkg = await np(options.version, options); | ||
|
|
||
| if (options.preview) { | ||
| return; | ||
| // Prefer the local installation | ||
| if (!importLocal(__filename)) { | ||
| if (isInstalledGlobally) { | ||
| console.log('Using global install of np.'); | ||
| } | ||
|
|
||
| console.log(`\n ${newPkg.name} ${newPkg.version} published 🎉`); | ||
| })().catch(error => { | ||
| console.error(`\n${logSymbols.error} ${error.message}`); | ||
| process.exit(1); | ||
| }); | ||
| // eslint-disable-next-line import/no-unassigned-import | ||
| require('./cli-implementation'); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be logged each time. You can use
util.debuglog.