Warn if no files field in package.json or .npmignore file present #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cironunes
force-pushed
the
103-npmignore-files
branch
2 times, most recently
from
e9d15ae
to
88e04ff
Compare
cironunes
commented
May 22, 2019
cironunes
force-pushed
the
103-npmignore-files
branch
from
88e04ff
to
b9ce621
Compare
itaisteinherz
requested changes
May 23, 2019
cironunes
force-pushed
the
103-npmignore-files
branch
from
b9ce621
to
1003fab
Compare
cironunes
force-pushed
the
103-npmignore-files
branch
3 times, most recently
from
e5daf5f
to
9409655
Compare
cironunes
force-pushed
the
103-npmignore-files
branch
8 times, most recently
from
e8bfdd7
to
479d49c
Compare
|
Fixed the conflict. Build is green again. |
cironunes
force-pushed
the
103-npmignore-files
branch
2 times, most recently
from
0babe33
to
a439c34
Compare
sindresorhus
requested changes
Jun 29, 2019
|
Can you mention it in https://github.com/sindresorhus/np#why ? |
cironunes
force-pushed
the
103-npmignore-files
branch
from
a439c34
to
fe06510
Compare
|
@sindresorhus I mentioned it and applied your other requests as well. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've read the discussion in #103 and I though: why not put a PR with some initial work up and see where it takes us?
I'm currently checking if the project has either a
filesfield specified in thepackage.jsonor an.npmignorefile in the root folder and just warning about it.Thoughts?
IssueHunt Summary
IssueHunt has been backed by the following sponsors. Become a sponsor