Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open github release page when release note is too long #501

Open
fisker opened this issue Feb 17, 2020 · 13 comments
Open

Can't open github release page when release note is too long #501

fisker opened this issue Feb 17, 2020 · 13 comments

Comments

@fisker
Copy link

fisker commented Feb 17, 2020

Description

This is a limitation on github urls, seems about 8195 (including https://github.com)

here

Expected behavior

I think maybe we can copy the body to clipboard and open a url like this

https://github.com/sindresorhus/np/releases/new?body=<!--%20paste%20your%20release%20notes%20here%20-->

Maybe new-github-release-url should also throw an error.

@sindresorhus
Copy link
Owner

Can you submit a bug report to GitHub? They should really support longer URLs than that.

@fisker
Copy link
Author

fisker commented Feb 17, 2020

I don't think that solves the problem, even if github supports longer urls, the url length can still reach the browser's url length limits. In chrome about 2MB

@sindresorhus
Copy link
Owner

Yes, but you're much less likely to hit the browser URL limit. So it's still worth sending a bug report.

@fisker
Copy link
Author

fisker commented Feb 17, 2020

OK, I'll let you know when they reply.

@sindresorhus
Copy link
Owner

That means about a million characters. If your release notes are that long, this is the least of your problems 😝

@fisker fisker changed the title Can't open github release page when release notes is too long Can't open github release page when release note is too long Feb 17, 2020
@papb
Copy link
Contributor

papb commented Oct 12, 2020

Hmm, something similar just happened to me, but instead of opening this 414 Request-URI Too Large error, nothing was opened at all... The release had 110 commits since the previous one, so I wonder if that enough blew the size up.

By the way, of those, almost 100 were commits by Renovate bot, which I redacted from the release notes while doing it manually, since np didn't work. I was expecting to get the generated release and just delete those commits from it.

@make-github-pseudonymous-again

2021-03-19-133120_426x196

@fregante
Copy link
Collaborator

fregante commented Feb 3, 2023

I think maybe we can copy the body to clipboard and open a url like this

This sounds reasonable

@sgarner
Copy link

sgarner commented Aug 1, 2023

This happens all the time for me due to automated dependency updates (by Renovate) and infrequent releases.

It would be great to simply have an option to disable automatic generation of release notes in np, since I only delete them anyway.

@tommy-mitchell
Copy link
Collaborator

tommy-mitchell commented Aug 2, 2023

@sgarner I believe you should be able to do that with np --no-release-draft (or by setting "releaseDraft": "false" in your np config)

@sgarner
Copy link

sgarner commented Aug 2, 2023

@tommy-mitchell I still want np create the draft release though, I just don't want it to pre-populate the notes in the body.

Of course, yes, I could create the release manually. But there is still some convenience in having np open the page and pre-populate the tag version.

@tommy-mitchell
Copy link
Collaborator

I still want np create the draft release though, I just don't want it to pre-populate the notes in the body.

Makes sense. Would you mind opening another issue suggesting that? If you have any ideas in mind for the option name, that’d be helpful too.

@sgarner
Copy link

sgarner commented Aug 2, 2023

Makes sense. Would you mind opening another issue suggesting that? If you have any ideas in mind for the option name, that’d be helpful too.

Sure, here's a new issue #708 and I had a go at a PR for it in #709 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants