Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect removal of trailing slash from a hash #82

Merged
merged 4 commits into from Dec 18, 2018
Merged

Fix incorrect removal of trailing slash from a hash #82

merged 4 commits into from Dec 18, 2018

Conversation

bitshadow
Copy link
Contributor

fixes #81

@sindresorhus
Copy link
Owner

Can you add some tests?

@sindresorhus sindresorhus changed the title Wrongly removes trailing slash from a hash Fix incorrect removal of trailing slash from a hash Dec 18, 2018
gajus
gajus reviewed Dec 18, 2018
View reviewed changes
test.js Outdated Show resolved Hide resolved
@gajus
Copy link

gajus commented Dec 18, 2018

LGTM.

@sindresorhus anything else that needs to be changed?

@sindresorhus sindresorhus merged commit 191ad4b into sindresorhus:master Dec 18, 2018
@gajus
Copy link

gajus commented Dec 18, 2018

@sindresorhus I highly recommend exploring viability of using https://github.com/semantic-release across all your projects. It saves me a lot of time.

@sindresorhus
Copy link
Owner

@gajus Couldn't use it even if I wanted to: semantic-release/npm#93

@erquhart erquhart mentioned this pull request Mar 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@gajus gajus gajus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrongly removes trailing slash from a hash
3 participants
@bitshadow @sindresorhus @gajus