Skip to content
This repository has been archived by the owner on Oct 8, 2022. It is now read-only.

Update to Reboot v4.3.1 and other changes #1

Merged
merged 10 commits into from Mar 25, 2019
Merged

Update to Reboot v4.3.1 and other changes #1

merged 10 commits into from Mar 25, 2019

Conversation

z0al
Copy link
Collaborator

@z0al z0al commented Mar 10, 2019

Hello,

I started my fork mainly to update reboot.css to the latest version, but later found myself made other changes.

Changes:

  • Reboot v4.3.1
  • No bundling, we clone a minified reboot.css
  • Added bootstrap as a dev dependency. The idea is to set up Greenkeeper to notify us of new bootstrap versions.
  • Automatic release with semantic-release with the help of Travis CI
  • Added a download script to automatically clone the latest minified reboot.css, and a tiny test to make sure it works.
  • package-lock.json instead of yarn.lock

So, to merge this PR, you need to:

  1. Setup Travis CI for semantic releasing.
  2. Setup Greenkeeeper.io

No pressure. If you think those changes are too much or may don't like the way I did things feel free to reject this PR.

@z0al
Copy link
Collaborator Author

z0al commented Mar 10, 2019

This is weird. I've no idea how to mark the PR as read-for-review. I thought there should a button somewhere here 0_o

@erquhart
Copy link
Owner

erquhart commented Mar 11, 2019

Weird, the Ready for review button is supposed to be showing for you, but instead they're showing it to me. That's new.

Anywhow, it looks like this repo is now obsolete - Bootstrap is providing a built copy of Reboot in their npm distribution: https://unpkg.com/bootstrap/dist/css/bootstrap-reboot.css

Going to add that link to the top of the readme and archive this puppy. If you feel I'm missing something and this repo still serves an unserved use case, let me know.

@erquhart
Copy link
Owner

Ah, nevermind, I see your PR is pulling from Bootstrap. I suppose it's worth being able to use Reboot without having the weight of Bootstrap as a dev dependency in your project. Awesome work on this PR - I'll get Travis and Greenkeeper set up soon 👍

@erquhart erquhart marked this pull request as ready for review March 11, 2019 15:06
Copy link
Owner

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @z0al 👍 👍

@erquhart erquhart merged commit 5738702 into erquhart:master Mar 25, 2019
@erquhart
Copy link
Owner

@z0al I use 2FA in npm, so semantic release won't work (semantic-release/npm#93). (Others have come to the same conclusion). We need to think of a way to do this with manual releases.

@erquhart
Copy link
Owner

Update: added you as a collaborator so you can hook up publishing if you don't use 2FA on npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants