Add TypeScript definition #4
Conversation
| | 'url'; | ||
|
|
||
| /** Helper type to flatten nested mapped types */ | ||
| declare type Identity<T> = {} & {[K in keyof T]: T[K]}; |
There was a problem hiding this comment.
This converts something like: Pick<IncomingMessage, Exclude<"complete", keyof T> | Exclude<"destroy", keyof T> | Exclude<"headers", keyof T> | Exclude<"httpVersion", keyof T> | Exclude<"httpVersionMinor", keyof T> | Exclude<"httpVersionMajor", keyof T> | Exclude<"method", keyof T> | Exclude<"rawHeaders", keyof T> | Exclude<"rawTrailers", keyof T> | Exclude<"setTimeout", keyof T> | Exclude<"socket", keyof T> | Exclude<"statusCode", keyof T> | Exclude<"statusMessage", keyof T> | Exclude<"trailers", keyof T> | Exclude<"url", keyof T>> (which is what mimicResponse gets interpreted as) into:
{
complete: boolean;
destroy: (error?: Error | undefined) => void;
headers: http.IncomingHttpHeaders;
httpVersion: string;
httpVersionMinor: number;
httpVersionMajor: number;
method?: string | undefined;
... 7 more ...;
url?: string | undefined;
}| @@ -33,4 +33,6 @@ module.exports = (fromStream, toStream) => { | |||
|
|
|||
| toStream[prop] = typeof fromStream[prop] === 'function' ? fromStream[prop].bind(fromStream) : fromStream[prop]; | |||
| } | |||
|
|
|||
| return toStream; | |||
There was a problem hiding this comment.
This makes it possible to alter the type of toStream.
|
I appreciate the PR, but I commented to @BendingBender exactly because I prefer him to do it. He knows exactly how to create the type definitions correctly. I don't really have time to review random TS definition submissions. |
sindresorhus
changed the title
|
Thanks :) |
See sindresorhus/meta#9 (comment)
review?(@BendingBender, @sindresorhus)