Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle dependencies #107

Closed
wants to merge 4 commits into from
Closed

Bundle dependencies #107

wants to merge 4 commits into from

Conversation

ianwalter
Copy link

@ianwalter ianwalter commented Jan 9, 2019

Trying to add #67 and to some extent #104 although I haven't measured startup performance yet.

@sindresorhus Is there a CLI you had in mind that I could use to test performance and any other tips on how I should do it?

@sindresorhus
Copy link
Owner

@ianwalter How does your module compare to ncc? I think I would prefer ncc now as they plan on adding features like V8 cache.

@ianwalter
Copy link
Author

ncc uses Webpack under the hood so it doesn't work with module.parent like @kevva mentioned in #67. I also tried parcel but that didn't work either.

Outputting a v8 cache file looks pretty straight forward from the ncc PR. I'll look to add that once I get a baseline to compare it to.

@sindresorhus
Copy link
Owner

Outputting a v8 cache file looks pretty straight forward from the ncc PR. I'll look to add that once I get a baseline to compare it to.

Any updates on this?

@ianwalter
Copy link
Author

Outputting a v8 cache file looks pretty straight forward from the ncc PR. I'll look to add that once I get a baseline to compare it to.

Any updates on this?

No update yet, but I'm going to work on this today and tomorrow.

@ianwalter
Copy link
Author

ianwalter commented Feb 24, 2019

Sorry for the confusion, but I'll have to re-create this.

@sindresorhus
Copy link
Owner

I would be happy to use your module if you're still interested in doing a PR? I'm getting closer to the next major release of meow now. If not, no worries :)

@ianwalter
Copy link
Author

ianwalter commented Jun 12, 2019

Sure, I'll create a new PR soon.

Edit: Ah, I remember now why I had to close this. There's this weird issue that I haven't had much time to dig into with Rollup and the fact that meow and dist both use read-pkg-up. I might be able to look into this more this weekend, but for now, it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants