Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package size and number of dependencies #177

Open
armano2 opened this issue Feb 22, 2021 · 1 comment
Open

Package size and number of dependencies #177

armano2 opened this issue Feb 22, 2021 · 1 comment

Comments

@armano2
Copy link

armano2 commented Feb 22, 2021

Hello, i'm a little concerned about size of this package and number of dependencies that it requires to run,

this package has 66 dependencies and weights 175kb with all its dependencies, as a comparison yargs has 16 dependencies and weights 76kb,

most of code in this package actually come from reading and normalizing package.json and that should be a trivial task as this package uses optionally 2 fields description and version.

my suggestion is to replace normalize-package-data and read-pkg-up with find-up and simple if condition.

this change should allow to reduce number of dependencies by half and reduce size by 70%

@sindresorhus
Copy link
Owner

I guess we could remove it, but it would be a breaking change as we expose the package as a .pkg object. We would also have to document that it's not normalized and how the user needs to manually normalize it if they want to access properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants