Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #91

Merged
merged 8 commits into from May 6, 2023
Merged

Update dependencies #91

merged 8 commits into from May 6, 2023

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented May 4, 2023

index.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@fregante
Copy link
Collaborator Author

fregante commented May 5, 2023

This is why I’ve been switching to vitest 🥲 there are some issues in the tests and they just timeout on my computer, haven’t had time to debug fully

@fregante
Copy link
Collaborator Author

fregante commented May 5, 2023

I think the “tsx” package offers better DX, but I think it doesn’t type-check. Do you want to try it? We’d have to add “test.ts” to tsconfig, which will cause it to be emitted into ./dist

@sindresorhus
Copy link
Owner

]
],
"ts-node": {
"transpileOnly": true
Copy link
Collaborator Author

@fregante fregante May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the tests in <=18, but Node 20 tests still broken even with the full

		"transpileOnly": true
		"files": true,
		"experimentalResolver": true

That's why I had initially excluded them


> xo && ava && npm run build && tsd


(node:1742) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
  Uncaught exception in test.ts

  TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /home/runner/work/mem/mem/test.ts

  ✘ test.ts exited with a non-zero exit code: 1
  ─

  1 uncaught exception
Error: Process completed with exit code 1.

@sindresorhus sindresorhus merged commit 22c4b5e into main May 6, 2023
4 checks passed
@sindresorhus sindresorhus deleted the update-deps branch May 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants