New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plan/interest to rewrite in TypeScript? #321
Comments
I'm personally on board with this. It would certainly be nice for Deno users, as it would remove the need to manually import the types. |
I'm not sure I want that. The Got rewrite to TS ended up being a nightmare. TS just so buggy. |
Why would you need to manually import the types? Can Deno really not infer it automatically? |
Deno imports modules directly from URLs. They have an excellent on-disk caching system so things get loaded from the file system when possible but they've made a design choice to not probe servers for There is an HTTP header that CDNs can use to explicitly point Deno to the TS types and it will then load them automatically. That's what the |
I can't attest for the ongoing maintenance burden of Also since Anyway, as maintainers it is your call to make. But if you do consider it in the future, I could spend some time on it, give it a try and see how it goes. |
There are multiple things:
Yes, there are obvious benefits too. TS linting has helped fix a lot of code. Refactoring is so much easier. Automatic That being said. Ky is considerably simpler than Got, so if any of you feel strongly about this and are willing to do the work, I will not be in your way. |
How would we type Lines 24 to 53 in 110aba8
|
Even if you put some general type as
|
Fixed by #330 |
Seeing that got is now 100% typescript, is there any plan or ongoing effort on porting this sister project to TypeScript?
The text was updated successfully, but these errors were encountered: