Add support for specifying a predicate to find a specific element

[bengry]

fixes #37

[sindresorhus]

This will need readme updates and tests.

[sindresorhus]

It should also be added to observeReadyElements.

[bengry]

This will need readme updates and tests.

I added this to the readme, but I can't run the tests locally since it seems like the typescript package is missing from devDependencies. Is that on purpose? I'm not sure how they pass in CI. I added some tests (see 77b3176), but couldn't run them.

It should also be added to observeReadyElements.

Done

[bengry]

On an unrelated note, is there a reason to maintain a separate .d.ts file, instead of re-writing the package in TypeScript? It's not large and a re-write should be simple enough.

[sindresorhus]

On an unrelated note, is there a reason to maintain a separate .d.ts file, instead of re-writing the package in TypeScript?

Yes. I don't like TS. I only provide types for user convenience. (sindresorhus/ky#321 (comment))

[sindresorhus]

You overwrote my changes: https://github.com/sindresorhus/element-ready/compare/8dc7b0c24363479246a6a2b4b3cf3d6da6f968c4..ed957e569374df606507811648b6f2730b983a2c

[sindresorhus]

Generally, don't force push in pull requests, it also makes it harder to review what changed.

[bengry]

You overwrote my changes: 8dc7b0c24363479246a6a2b4b3cf3d6da6f968c4..ed957e569374df606507811648b6f2730b983a2c (compare)

I've re-added them in add7485. If I understood correctly - with the last push all that was overridden was the missing import elementReady from 'element-ready'; from the docs. Since there were both this and the suggestions (which I've implemented separately) in the diffs.

Please LMK if I missed anything.

[sindresorhus]

There were a few other changes too. Just look at the diff I commented.

[bengry]

There were a few other changes too. Just look at the diff I commented.

Right, but there were also the suggestion, so I think that together we're all aligned now: https://github.com/sindresorhus/element-ready/compare/8dc7b0c24363479246a6a2b4b3cf3d6da6f968c4..add7485

[sindresorhus]

I committed some small tweaks.

[sindresorhus]

The "check elements against a predicate" test is failing though.

[bengry]

The "check elements against a predicate" test is failing though.

Fixed in cd1f75a. There were some errors due to some renaming I did while working on the tests, and using a non-existent property on the element in the assertion. Funnily enough, these errors would've been caught by TypeScript.

[sindresorhus]

Thanks :)