Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop non-working default export for TypeScript users #89

Closed
wants to merge 9 commits into from
Closed

Drop non-working default export for TypeScript users #89

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c8b90f
Restore non-interop ES Modules support
fregante May 16, 2019
e4b9bcd
Lint: trailing whitespace
fregante May 16, 2019
cd6949d
Real ESM export to fool `eslint#import/default`
fregante May 16, 2019
58daa3e
/2
fregante May 16, 2019
1dce31d
Drop default export
fregante May 18, 2019
d3fdab0
Change import to require in tests
fregante May 19, 2019
c017888
Change import to require in tests /2
fregante May 19, 2019
c4d100a
lint
fregante May 19, 2019
60e0b3c
Restore ESM import
fregante May 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions source/index.ts
View file
Open in desktop
Expand Up @@ -385,5 +385,4 @@ Object.defineProperties(is, {
}
});

module.exports = is; // For CommonJS default export support
export default is;
export = is;
6 changes: 5 additions & 1 deletion test/test.ts
View file
Open in desktop
Expand Up @@ -7,11 +7,15 @@ import test, {ExecutionContext} from 'ava';
import {JSDOM} from 'jsdom';
import {Subject, Observable} from 'rxjs';
import ZenObservable from 'zen-observable';
import is, {TypeName} from '../source';

// eslint-disable-next-line @typescript-eslint/no-require-imports
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either import/default follows esModuleInterop and therefore allows import X from Y on CJS modules, or @typescript-eslint/no-require-imports should be disabled.

Since I have to disable a rule, I might as well leave the old ESM import and disable import/default on that line

import is = require('../source');

// eslint-disable-next-line @typescript-eslint/no-require-imports
const URLGlobal = typeof URL === 'undefined' ? require('url').URL : URL;

const {TypeName} = is;

const isNode10orHigher = Number(process.versions.node.split('.')[0]) >= 10;

class PromiseSubclassFixture<T> extends Promise<T> {}
Expand Down